Support ps-max-modem #273
Merged
Support ps-max-modem #273
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
bugadani
reviewed
Oct 11, 2023
| @@ -153,6 +153,10 @@ struct Config { | |||
| heap_size: usize, | |||
| #[default(DEFAULT_TICK_RATE_HZ)] | |||
| tick_rate_hz: u32, | |||
| #[default(3)] | |||
| listen_interval: u16, | |||
| #[default(6)] | |||
There was a problem hiding this comment.
@bjoernQ If this default is used, starting AP panics. Quoting from https://docs.espressif.com/projects/esp-idf/en/latest/esp32/api-reference/network/esp_wifi.html#_CPPv426esp_wifi_set_inactive_time16wifi_interface_t8uint16_t
ESP_ERR_INVALID_ARG: invalid argument, For Station, if sec is less than 3. For SoftAP, if sec is less than 10.
I believe a different config should be provided for AP and STA modes.
|
I already found the problem - will create a PR tomorrow |
|
Ah okay I was about to edit my comment saying that AP panics regardless of the beacon interval, but I guess that's not needed now :) |
|
#281 should be a fix Somewhat embarrassing since I knew before it's not fine to set it for AP mode 🤦♂️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have support for
ps-min-modempower-safe mode for quite a long time - this also adds support forps-max-modemLike
ps-min-modemit's activated by a feature.No power-safe
ps-min-modem
ps-max-modem
